Have you convinced @balloob already about this?

Have you convinced @balloob already about this?

🙏

Moved the action handling to the generic-row's name after some discussion with @balloob.
Only issue I currently see is that the input-select row doesn't use the generic-row and only displays the state-badge to the left.

I am fine with these changes if it does not hurt accessibility. Are we able to use the tab key to select the name and open the more info?

I am fine with these changes if it does not hurt accessibility. Are we able to use the tab key to select the name and open the more info?

We don't currently support this, the only thing that is selectable on the demo by tab are controls which is still true after my change.

@balloob while checking tabs, I'm finding lots of holes in our accessibility features. i.e. you can't highlight many elements, can't trigger anything associated with long-press using enter or ha-switch. @bramkragten and I are thinking that 0.102 should be a feature-freeze release with focus on these issues and hacktoberfest cleanup.

With that in mind, I think this should be good to merge for 0.101 beta. Thanks.

Accessibility is very important. Not supporting that would literally cause us to exclude an already vulnerable part of the people. We've been slowly working on improving accessibility but still have a long way to go. Saying that we currently have a lot of big holes is not a reason to add to it. If we can't mark the element as interactive and allow tabbing to it to allow the user to activate the click handler using a keyboard, we shouldn't merge this. Double click and long press we can ignore, as they won't be part of the default generated UI config.

@balloob I'm not taking away any accessibility as our current rows are not marked and I think it would be misleading to mark it as interactive now until we fix the click handler.

I'm down to merge this PR and add this feature, but we should make sure that it won't break our path to making these elements interactive. Because if that happens, we would end up having to remove it again, which pisses people off too. That's why I want to make sure that keyboard nav still works. And if we don't have examples of this working with long press directive, nor are we able to make it work, then the long press directive should not be used.

I think that it can work if we use a <button> or an <a> tag with href attribute + preventDefault() in the click listener.

That's why I want to make sure that keyboard nav still works

It doesn't work currently, is what I'm saying.

Regardless, I've pushed a commit that allows us to handle enter in long-press elements and made the state-badge (as input-select doesn't have a name in the row) to be tabbable and brings up the tap-action on enter.